[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2033fa29b09f: Add documentation illustrating use of IgnoreUnlessSpelledInSource (authored by stephenkelly). Repository: rG LLVM Github Monorepo C

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the new documentation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91639/new/ https://reviews.llvm.org/D9163

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

steveire updated this revision to Diff 306634. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91639/new/ https://reviews.llvm.org/D91639 Files: clang/docs/LibASTMatchersReference.html Index: clang/docs/LibASTMatc

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

steveire added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:91-94 +This mode is hard to use correctly and +requires more development iteration because it means +that the user must write AST Matchers to explicitly traverse or ignore nodes +which are not vis

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

aaron.ballman added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:91-94 +This mode is hard to use correctly and +requires more development iteration because it means +that the user must write AST Matchers to explicitly traverse or ignore nodes +which are no

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

steveire added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:303 + + Replacement of `begin()` with `cbegin()`: + aaron.ballman wrote: > Backticks won't help here -- should probably use tags. `pre` is equivalent to three backticks. I added

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

steveire updated this revision to Diff 306494. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91639/new/ https://reviews.llvm.org/D91639 Files: clang/docs/LibASTMatchersReference.html Index: clang/docs/LibASTMatc

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

aaron.ballman added a comment. Thank you for the documentation effort! Comment at: clang/docs/LibASTMatchersReference.html:100 + +Traverse Mode + I think this section should go above the Node Matchers section in the document so that Node Matchers stays directl

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

steveire updated this revision to Diff 305863. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91639/new/ https://reviews.llvm.org/D91639 Files: clang/docs/LibASTMatchersReference.html Index: clang/docs/LibASTMatc

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91639 Files: clang/docs/LibASTMatchersRef