[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 306115. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tool

[PATCH] D91626: [clangd] Implement textDocument/implementation.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The patch description is a bit stale now. Comment at: clang-tools-extra/clangd/XRefs.cpp:1130 + std::vector Results; + // We rely on index to find the implementations in su

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 306079. usaxena95 added a comment. Added test for no implementation for concrete methods. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/c

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1153 + Index->relations(Req, [&](const SymbolID &Subject, const Symbol &Object) { +if (auto Loc = symbolToLocation(Object, *MainFilePath)) + Results.References.push_back(*Loc); -

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 306076. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tool

[PATCH] D91626: [clangd] Implement textDocument/implementation.

hokein added a comment. thanks, just reviewed at the xrefs code. I think we can narrow the scope of the patch by splitting it into two patches - find-implementation in xrefs.cpp - LSP & clangd server layer (needs a smoke lit test) Comment at: clang-tools-extra/clangd/XRefs.c

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305974. usaxena95 added a comment. Remove unintended change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp c

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305972. usaxena95 added a comment. Addressed final comments. Ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/clangd/ClangdLS

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305835. usaxena95 edited the summary of this revision. usaxena95 added a comment. Minor fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-ex

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305825. usaxena95 added a comment. Refactor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305808. usaxena95 added a comment. Typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305800. usaxena95 added a comment. Herald added a subscriber: wenlei. Type fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/clangd/Clan

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91626 Files: