This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4bc085f5b3ed: [clangd] Add OverridenBy Relation to index.
(authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
usaxena95 updated this revision to Diff 305976.
usaxena95 marked an inline comment as done.
usaxena95 added a comment.
Addressed final comments. Ready to land.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91610/new/
https://reviews.llvm.org/D91610
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/Relation.h:31
+/// { Subject = A, Predicate = BaseOf, Object = B }.
+/// - "A::Foo is overriden by B::Foo" is represented
usaxena95 updated this revision to Diff 305802.
usaxena95 added a comment.
Typo fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91610/new/
https://reviews.llvm.org/D91610
Files:
clang-tools-extra/clangd/index/Relation.cpp
clang-tools-extra/
usaxena95 updated this revision to Diff 305787.
usaxena95 marked an inline comment as done.
usaxena95 added a comment.
Add documentation for change in index test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91610/new/
https://reviews.llvm.org/D91
usaxena95 updated this revision to Diff 305783.
usaxena95 marked 2 inline comments as done.
usaxena95 added a comment.
s/OverridenBy/OverriddenBy
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91610/new/
https://reviews.llvm.org/D91610
Files:
cla
usaxena95 added inline comments.
Comment at: clang-tools-extra/clangd/index/Relation.h:24
BaseOf,
+ OverridenBy,
};
Quuxplusone wrote:
> s/Overriden/Overridden/g
Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llv
kadircet added inline comments.
Comment at:
clang-tools-extra/clangd/test/index-serialization/Inputs/sample.cpp:6
+struct Bar : public Foo {
+ void Func() override {}
+};
could you also add a comment for the reason we have this in the test (i.e.
Introduces an