[PATCH] D91602: [clang-tidy] Make clang-format and include-order-check coherent

2020-11-17 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/llvm-include-order.cpp:1 // RUN: %check_clang_tidy %s llvm-include-order %t -- -- -isystem %S/Inputs/Headers kadircet wrote: > njames93 wrote: > > Would it be wise to speci

[PATCH] D91602: [clang-tidy] Make clang-format and include-order-check coherent

2020-11-17 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/llvm-include-order.cpp:1 // RUN: %check_clang_tidy %s llvm-include-order %t -- -- -isystem %S/Inputs/Headers njames93 wrote: > Would it be wise to specify a format style he

[PATCH] D91602: [clang-tidy] Make clang-format and include-order-check coherent

2020-11-17 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5a9f3867046c: [clang-tidy] Make clang-format and include-order-check coherent (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91602/new

[PATCH] D91602: [clang-tidy] Make clang-format and include-order-check coherent

2020-11-17 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Thanks for fixing this, been bugging me for a while. Comment at: clang-tools-extra/test/clang-tidy/checkers/llvm-include-order.cpp:1 // RUN: %check_clang_tidy %s llvm-include-order %t -- -- -isystem %S/Inputs/Headers Would it be wi

[PATCH] D91602: [clang-tidy] Make clang-format and include-order-check coherent

2020-11-17 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 305707. kadircet added a comment. - Add gmock header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91602/new/ https://reviews.llvm.org/D91602 Files: clang-tools-extra/clang-tidy/llvm/IncludeOrderCheck.cpp

[PATCH] D91602: [clang-tidy] Make clang-format and include-order-check coherent

2020-11-17 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. kadircet requested review of this revision. LLVM style puts both gtest and gmock to the end of the include list. But llvm-include-order-check was only