This revision was automatically updated to reflect the committed changes.
Closed by commit rG5834996fefc9: [Frontend] Add flag to allow PCM generation
despite compiler errors (authored by bnbarham, committed by akyrtzi).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://r
bnbarham updated this revision to Diff 305914.
bnbarham added a comment.
Have allow-pcm also set allow-pch + test to make sure that works.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91580/new/
https://reviews.llvm.org/D91580
Files:
clang/include/clang/Driver/Options.td
clang/inc
akyrtzi added a comment.
I'd like if we only had to use one flag (`-fallow-pcm-with-compiler-errors`)
and have it handle both modules and PCH. Could you make the flag also work for
PCH and/or add a test that verifies it works?
You may only have to change
Opts.AllowPCHWithCompilerErrors = Args
bnbarham updated this revision to Diff 305622.
bnbarham added a comment.
Noticed I had left in the `-fdisable-module-hash` flags in the test, removed
now.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91580/new/
https://reviews.llvm.org/D91580
Files:
clang/include/clang/Driver/Optio
bnbarham created this revision.
bnbarham added a reviewer: akyrtzi.
Herald added subscribers: cfe-commits, dang, arphaman.
Herald added a project: clang.
bnbarham requested review of this revision.
As with precompiled headers, it's useful for indexers to be able to
continue through compiler errors
