This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2c7e24c4b689: Guard init_priority attribute within libc++
(authore
zibi marked an inline comment as done.
zibi added inline comments.
Comment at: clang/test/SemaCXX/init-priority-attr.cpp:26
Two foo __attribute__((init_priority(101))) ( 5, 6 );
+#if defined(__MVS__)
+ #if defined(SYSTEM)
aaron.ballman wrote:
> Rather than using
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM, thank you for the fixes!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91565/new/
https://reviews.llvm.org/D91565
___
cfe-commit
zibi updated this revision to Diff 306753.
zibi added a comment.
Make test cleaner.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91565/new/
https://reviews.llvm.org/D91565
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/Att
ldionne accepted this revision as: libc++.
ldionne added a comment.
LGTM from libc++'s perspective. You should wait until the Clang part is LGTM'd
before committing, of course.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91565/new/
https://revie
aaron.ballman added inline comments.
Comment at: clang/test/SemaCXX/init-priority-attr.cpp:26
Two foo __attribute__((init_priority(101))) ( 5, 6 );
+#if defined(__MVS__)
+ #if defined(SYSTEM)
Rather than using the preprocessor, you can assign a prefix to be chec
zibi updated this revision to Diff 306524.
zibi marked an inline comment as done.
zibi added a comment.
updated doc. and test as requested
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91565/new/
https://reviews.llvm.org/D91565
Files:
clang/incl
zibi marked an inline comment as done.
zibi added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:384
+def ExcludeTarget : TargetSpec {
+ let CustomCode = [{ !Target.getTriple().isOSzOS() }];
aaron.ballman wrote:
> This is not a very descriptive
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:384
+def ExcludeTarget : TargetSpec {
+ let CustomCode = [{ !Target.getTriple().isOSzOS() }];
This is not a very descriptive name -- if this is only supposed to be used for
`in
zibi updated this revision to Diff 306183.
zibi marked an inline comment as done.
zibi added a comment.
Moving macro to common place as requested. This makes assumption that MS and
Apple restrictions were lifted at some point.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.
Comment at: libcxx/include/experimental/__config:80
+// Detect if the init_priority attribute is supported.
+#if (defined(_LIBCPP_COMPILER_GCC) && defined(__A
zibi updated this revision to Diff 306162.
zibi marked an inline comment as done.
zibi added a comment.
Herald added a reviewer: aaron.ballman.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
I moved the logic from `memory_resource.cpp` to `__config` as since I'm not
famili
12 matches
Mail list logo
