This revision was automatically updated to reflect the committed changes.
abidh marked an inline comment as done.
Closed by commit rG8cdc53887387: Add sysroot/lib to library search path of
baremetal toolchain. (authored by abidh).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
abidh marked an inline comment as done.
abidh added inline comments.
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:39
+llvm::sys::path::append(SysRoot, "lib");
+getFilePaths().push_back(std::string(SysRoot.str()));
+ }
jroelofs wrote:
> Is the ex
abidh updated this revision to Diff 306036.
abidh added a comment.
Handle review comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91559/new/
https://reviews.llvm.org/D91559
Files:
clang/lib/Driver/ToolChains/BareMetal.cpp
clang/test/Driver/baremetal.cpp
Index: clang/test/Dr
jroelofs accepted this revision.
jroelofs added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:39
+llvm::sys::path::append(SysRoot, "lib");
+getFilePaths().push_back(std::string(SysRoot.str()));
+ }
abidh created this revision.
abidh added reviewers: jroelofs, clang.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
abidh requested review of this revision.
Baremetal toolchain is not adding sysroot/lib to the library
search path. This is forcing the user to do it manually.