This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2d1f471e45af: [Mach0] Fix unused-variable warnings (authored
by ehjogab, committed by dstenb).
Herald added a project: LLVM.
Changed prior to commit
ehjogab updated this revision to Diff 305984.
ehjogab added a comment.
Replace dyn_cast with isa
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91519/new/
https://reviews.llvm.org/D91519
Files:
clang/lib/AST/APValue.cpp
lld/MachO/SymbolTable.cp
arsenm added inline comments.
Comment at: lld/MachO/SymbolTable.cpp:137
// error message.
-if (auto *defined = dyn_cast(s))
+if (dyn_cast(s))
error("found defined symbol with illegal name " + DSOHandle::name);
Should use isa
Repository:
rG
ehjogab created this revision.
ehjogab added reviewers: dsanders, arsenm, qcolombet, ab, bjope, rovka.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
ehjogab requested review of this revision.
Herald added a subscriber: wdng.
Change-Id: Id37948be57aad3551eb14fc16b2aea2441a4
