[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan updated this revision to Diff 345931. leonardchan added a comment. Update to some feedback from first round of reviews. Minor refactoring of code that can be shared between the linux and fuchsia implementations. Still need to discuss refactoring the hwasan threads implementation. R

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan planned changes to this revision. leonardchan added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_dynamic_shadow.cpp:120 + +void InitShadowGOT() {} + Add comment. Fuchsia never uses dynamic shadow, which is what this sets up in the Linux

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan updated this revision to Diff 343468. leonardchan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91466/new/ https://reviews.llvm.org/D91466 Files: clang/cmake/caches/Fuchsia-stage2.cmake compiler-rt/cmake/c

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan updated this revision to Diff 335951. leonardchan added a comment. Rebase against submitted changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91466/new/ https://reviews.llvm.org/D91466 Files: clang/cmake/caches/Fuchsia-stage2.cm

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

phosek added a comment. @leonardchan would it be possible to break up this patch into multiple changes: - Clang driver - Cache file - `hwasan_new_delete.cpp` - `HWAddressSanitizer.cpp` - `sanitizer_platform_limits_fuchsia.h` - `sanitizer_symbolizer_markup.cpp` - the rest Repository: rG LLVM G

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:100-101 Dyld += "tsan/"; +if (SanArgs.needsHwasanRt() && SanArgs.needsSharedRt()) + Dyld += "hwasan/"; Dyld += "ld.so.1"; Nit: can you move this above TSan so i

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan added a comment. In D91466#2395297 , @pcc wrote: > How does Zircon handle tagged addresses in syscalls? Are they handled > equivalently to Linux's tagged address ABI? Woops, accidentally let this slide. I'm guessing you saw this in the Fuchsi

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan updated this revision to Diff 317118. leonardchan added a comment. Herald added subscribers: llvm-commits, jfb, hiraditya. Herald added a project: LLVM. Locally I'm able to build and run the `bringup.arm64` config (that is launch the shell and run some commands). Repository: rG LL

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

pcc added a comment. How does Zircon handle tagged addresses in syscalls? Are they handled equivalently to Linux's tagged address ABI? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91466/new/ https://reviews.llvm.org/D91466 __

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added projects: Sanitizers, clang. Herald added subscribers: Sanitizers, mgorny. leonardchan requested review of this revision. This tracks all the compiler/llvm changes needed for building Fuchsia with t