[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

dmajor added a comment. In D91330#2394415 , @kadircet wrote: > Looks like it is already green at > http://lab.llvm.org:8011/#/builders/109/builds/2693 Yep, I'm seeing the same, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet added a comment. Looks like it is already green at http://lab.llvm.org:8011/#/builders/109/builds/2693 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.llvm.org/D91330 _

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet added a comment. should be fixed with  https://github.com/llvm/llvm-project/commit/8dc2aa0e412171dad5cdc1aa60a92ddcd3800202. please let me know if it doesn't work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.l

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

dmajor added a comment. This broke the bots: http://lab.llvm.org:8011/#/builders/109/builds/2682 File "/b/1/clang-x86_64-debian-fast/llvm.obj/tools/clang/tools/extra/clangd/test/lit.site.cfg.py", line 35 config.have_zlib = ^ SyntaxError: invalid syntax Repo

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8741a76f5dd1: [clangd] Ensure we test for compatibility of serialized index format (authored by kadircet). Repository: rG LLVM Github Monorepo CH

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet updated this revision to Diff 305106. kadircet added a comment. - Drop subshell usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.llvm.org/D91330 Files: clang-tools-extra/clangd/test/index-serialization/Inpu

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet updated this revision to Diff 305100. kadircet added a comment. - Drop comment markers - Make failure print the doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.llvm.org/D91330 Files: clang-tools-extra/clangd

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

sammccall added inline comments. Comment at: clang-tools-extra/clangd/test/index-serialization/version-is-correct.test:15 +# indexing sample.cpp would yield non-trivial values for those. +# RUN: dexp %/S/Inputs/sample.idx -c="find B" | grep Bar + as discussed of

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet updated this revision to Diff 305096. kadircet added a comment. - Update comments - Query for Bar - Only run with zlib Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.llvm.org/D91330 Files: clang-tools-extra/cla

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

sammccall added a comment. Very nice, thanks for doing this! Comment at: clang-tools-extra/clangd/test/index-serialization/version-is-correct.test:1 +# If this test fails it means there has been a backward incompatilbe change to +# serialization format. Please bump the version

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet added a comment. As a side note, I've tested with a clangd-indexer before https://github.com/llvm/llvm-project/commit/71064b02701dd65065dd412fb01afe81ff83f746 and we got the failure (malformed/truncated refs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, wenlei, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monore