[PATCH] D91239: Update attribute example to fit the new Annotation API

2020-11-11 Thread Tyker via Phabricator via cfe-commits
Tyker added a comment. I recently made it much easier to create AnnotationAttr in this context with https://reviews.llvm.org/rGd093401a2617d3c46aaed9eeaecf877e3ae1a9f1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91239/new/ https://reviews.llvm.

[PATCH] D91239: Update attribute example to fit the new Annotation API

2020-11-11 Thread Yafei Liu via Phabricator via cfe-commits
psionic12 added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:59 + +// First we have to create an `StringLiteralExpr`. +StringRef AnnotationString = "example"; `AnnotationAttr` is used as an extra information in attribute plugin desi

[PATCH] D91239: Update attribute example to fit the new Annotation API

2020-11-11 Thread Yafei Liu via Phabricator via cfe-commits
psionic12 created this revision. psionic12 added reviewers: john.brawn, aaron.ballman, Tyker, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. psionic12 requested review of this revision. Since AnnotationAttr can add extra arguments now, update Attribute plugin ex