[PATCH] D91158: Fix the DeclContextLookupResult::iterator non-copyable.

2020-11-10 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d85f732b13a: Fix the DeclContextLookupResult::iterator non-copyable. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D91158: Fix the DeclContextLookupResult::iterator non-copyable.

2020-11-10 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/DeclBase.h:1249 llvm::iterator_adaptor_base; + std::random_access_iterator_tag, NamedDec

[PATCH] D91158: Fix the DeclContextLookupResult::iterator non-copyable.

2020-11-10 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein requested review of this revision. The value_type is a const pointer, which makes the iteator non-copyable. Before the patch, the normal usage like below was illegal: auto It = lookupresult.b