[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cb976e014db: [clangd] Call hierarchy (ClangdServer layer) (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

nridge updated this revision to Diff 306953. nridge added a comment. Update as per API changes in xrefs patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91123/new/ https://reviews.llvm.org/D91123 Files: clang-tools-extra/clangd/ClangdServer.c

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:695 +Callback>> CB) { + CB(clangd::incomingCalls(Item, Index)); +} nridge wrote: > kadirce

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

nridge added a comment. In D91123#2387032 , @kadircet wrote: > can you also add some tests to ClangdTests.cpp ? It seems like they would be highly duplicative of the tests in CallHierarchyTests.cpp. Comment at: clang-tools-extra/clang

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

nridge updated this revision to Diff 305408. nridge marked 2 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91123/new/ https://reviews.llvm.org/D91123 Files: clang-tools-ext

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

kadircet added a comment. can you also add some tests to ClangdTests.cpp ? Comment at: clang-tools-extra/clangd/ClangdServer.cpp:695 +Callback>> CB) { + CB(clangd::incomingCalls(Item, Index)); +} why do we run this on the mainthread ? I suppose we should j

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://rev