This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf6b02ecd027a: APINotes: add property models for YAML
attributes (authored by compnerd).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
Thanks, looks good to me!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91104/new/
https://reviews.llvm.org/D91104
__
compnerd added inline comments.
Comment at: clang/include/clang/APINotes/Types.h:529
+ /// Adds the return type info.
+ void addReturnTypeInfo(NullabilityKind kind) { addTypeInfo(0, kind); }
+
compnerd wrote:
> martong wrote:
> > Do we document somewhere that t
compnerd updated this revision to Diff 306487.
compnerd marked 5 inline comments as done.
compnerd added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91104/new/
https://reviews.llvm.org/D91104
Files:
clang/inc
compnerd marked 2 inline comments as done.
compnerd added inline comments.
Comment at: clang/include/clang/APINotes/Types.h:60
+ /// Whether SwiftPrivate was specified.
+ unsigned SwiftPrivateSpecified : 1;
+
martong wrote:
> I was wondering whether Swift speci
martong added inline comments.
Comment at: clang/include/clang/APINotes/Types.h:60
+ /// Whether SwiftPrivate was specified.
+ unsigned SwiftPrivateSpecified : 1;
+
I was wondering whether Swift specific properties are meaningful to all
descendants of `CommonE
compnerd added a comment.
Ping; I'd let to get this sorted out so I can continue to make progress towards
serialization and deserialization.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91104/new/
https://reviews.llvm.org/D91104
compnerd added a comment.
@martong since you hard expressed interest in the "user-visible" version of the
data types for the notes, I opted to get them out first. This set of data
types are user-facing rather than the previous one that were mistook for them.
Subsequent changes will actually a
compnerd created this revision.
compnerd added reviewers: martong, MForster, gribozavr2.
Herald added subscribers: rnkovacs, mgorny.
Herald added a project: clang.
compnerd requested review of this revision.
This adds internal representation of the attributes in a more usable
form. This is meant
