This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGca892f46fe12: [clangd] Enhance Clangd rename testing
coverage (authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
kbobyrev updated this revision to Diff 304077.
kbobyrev marked 3 inline comments as done.
kbobyrev added a comment.
Resolve comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91102/new/
https://reviews.llvm.org/D91102
Files:
clang-tools-ext
kbobyrev updated this revision to Diff 304076.
kbobyrev added a comment.
Also add class tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91102/new/
https://reviews.llvm.org/D91102
Files:
clang-tools-extra/clangd/unittests/RenameTests.cpp
In
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks. Please update the patch description when landing it (the description is
stale now).
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:95
- // rename is
kbobyrev updated this revision to Diff 304071.
kbobyrev marked 3 inline comments as done.
kbobyrev added a comment.
Resolve comments. Since member tests seem to be covered already, add enum and
alias tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
hokein added a comment.
thanks for doing this!
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:525
+
+TEST_F(WithinFileRenameTest, Member) {
+ Tests = {
I'm not sure about the motivation of having a separated `TEST_F`, are these
tests special?
kbobyrev updated this revision to Diff 303980.
kbobyrev added a comment.
Move NewName constant to class field.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91102/new/
https://reviews.llvm.org/D91102
Files:
clang-tools-extra/clangd/unittests/Ren
kbobyrev created this revision.
kbobyrev added a reviewer: hokein.
Herald added subscribers: cfe-commits, usaxena95, arphaman.
Herald added a project: clang.
kbobyrev requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
We plan to eliminate error-prone and obsolete
