[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

steveire added a comment. I've removed the offending test (which in this case is the correct fix - it is not a temporary fix). @RKSimon Is there some way I can see what is causing the failures on the other platforms? Was it because of this test? How can I monitor this? I knew how to see it in

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

RKSimon added subscribers: stephenkelly, RKSimon. RKSimon added a comment. @stephenkelly This is breaking a large number of bots - please can you revert your patch series to get things green again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9098

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

leonardchan added a comment. Hi. I suspect it might be this patch or D90984 that might be leading to the test failure we're seeing on our arm64 builders FAIL: Clang-Unit :: AST/./ASTTests/Traverse.IgnoreUnlessSpelledInSourceImplicit (15871 of 26886) **

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

thakis added a comment. (usual procedure is to revert while investigating test failures instead of commenting out the tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90982/new/ https://reviews.llvm.org/D90982

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG246b428fb3b5: [AST] Ignore implicit nodes in IgnoreUnlessSpelledInSource mode (authored by stephenkelly). Changed prior to commit: https://reviews

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:164 auto *LambdaNode = dyn_cast_or_null(StmtNode); - if (LambdaNode && !Finder

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

steveire updated this revision to Diff 305767. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90982/new/ https://reviews.llvm.org/D90982 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ASTNodeTraverse

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

aaron.ballman added a comment. Thank you for this, I think it's mostly looking good! Comment at: clang/include/clang/AST/ASTNodeTraverser.h:88 void Visit(const Decl *D) { +if (Traversal != TK_AsIs && D->isImplicit()) + return; Similar to the feedbac

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

steveire updated this revision to Diff 304103. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90982/new/ https://reviews.llvm.org/D90982 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ASTNodeTraverse

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

steveire updated this revision to Diff 303728. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90982/new/ https://reviews.llvm.org/D90982 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/ASTM

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

steveire updated this revision to Diff 303682. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90982/new/ https://reviews.llvm.org/D90982 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/ASTM

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

steveire updated this revision to Diff 303679. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90982/new/ https://reviews.llvm.org/D90982 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/ASTM

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Update the ASTNodeTraverser to dump only nodes spelled in source. There are only a few which need to be hand