This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7b7170fa5791: [clang-format] avoid introducing multiline
comments (authored by krasimir).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
sammccall accepted this revision.
sammccall added a comment.
Still LG
Comment at: clang/lib/Format/BreakableToken.cpp:109
+// after '\'.
+if (Style.isCpp()) {
+ StringRef::size_type LastNonBlank =
krasimir wrote:
> sammccall wrote:
> > Do we really
krasimir added inline comments.
Comment at: clang/lib/Format/BreakableToken.cpp:109
+// after '\'.
+if (Style.isCpp()) {
+ StringRef::size_type LastNonBlank =
sammccall wrote:
> Do we really want to predicate this on isCpp()? `//` comments are allowe
krasimir updated this revision to Diff 303788.
krasimir marked 3 inline comments as done.
krasimir added a comment.
- address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90949/new/
https://reviews.llvm.org/D90949
Files:
clang/l
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
One concern about looping, otherwise just style nits.
Comment at: clang/lib/Format/BreakableToken.cpp:104
static const auto kNumberedListRegexp = llvm::Regex("^[1-9]
krasimir created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
krasimir requested review of this revision.
In C++ with -Werror=comment, multiline comments are not allowed.
clang-format could accidentally introduce multiline comments when reflowing.
This adap
