[PATCH] D90928: [OpenCL] Check for extension string extension lookup

2020-11-27 Thread Fraser Cormack via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7793db35ca2c: [OpenCL] Check for extension string extension lookup (authored by erik2020, committed by frasercrmck). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

2020-11-26 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Great! LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90928/new/ https://reviews.llvm.org/D90928 ___

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

2020-11-24 Thread Erik Tomusk via Phabricator via cfe-commits
erik2020 updated this revision to Diff 307338. erik2020 added a comment. Added doxygen comments to updated functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90928/new/ https://reviews.llvm.org/D90928 Files: clang/include/clang/Basic/OpenCL

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

2020-11-23 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:47 bool isSupported(llvm::StringRef Ext, const LangOptions &LO) const { +auto E = OptMap.find(Ext); +if (E == OptMap.end()) { erik2020 wrote: > Anastasia wrote: > >

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

2020-11-23 Thread Erik Tomusk via Phabricator via cfe-commits
erik2020 added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:47 bool isSupported(llvm::StringRef Ext, const LangOptions &LO) const { +auto E = OptMap.find(Ext); +if (E == OptMap.end()) { Anastasia wrote: > Btw how about we use

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

2020-11-23 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D90928#2408249 , @erik2020 wrote: > In D90928#2405796 , @Anastasia wrote: > >> Do you think we could improve testing? I presume there is something that >> triggers a failure without yo

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

2020-11-20 Thread Erik Tomusk via Phabricator via cfe-commits
erik2020 added a comment. In D90928#2405796 , @Anastasia wrote: > Do you think we could improve testing? I presume there is something that > triggers a failure without your change... I'm not really sure how to test this code. Best I can tell, there's no

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

2020-11-19 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. LGTM for the fix! Do you think we could improve testing? I presume there is something that triggers a failure without your change... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90928/new/ https://reviews.llvm.org/D9092