[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG17497ec514f7: [AIX][FE] Support constructor/destructor attribute (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https:/

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

sfertile accepted this revision. sfertile added a comment. Thanks for the updates. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 305526. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Update testcases; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/C

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 5 inline comments as done. Xiangling_L added inline comments. Comment at: clang/test/CodeGen/aix-constructor-attribute.cpp:8 -int foo() __attribute__((constructor(180))); +// CHECK: @llvm.global_ctors = appending global [3 x { i32, void ()*, i8* }] [{ i32, v

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

sfertile added inline comments. Comment at: clang/test/CodeGen/aix-constructor-attribute.cpp:8 -int foo() __attribute__((constructor(180))); +// CHECK: @llvm.global_ctors = appending global [3 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* bitcast (i32

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 304896. Xiangling_L added a comment. Fix minor issues in the testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGenFunction.h cla

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 304616. Xiangling_L added a comment. Add testcases to both CodeGen and CodeGenCXX folder; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L added a comment. In D90892#2386908 , @aaron.ballman wrote: > I think this generally seems reasonable, but I'm far from an AIX expert so > you should wait a few days in case other reviewers have feedback. Thanks for reviews. And @sfertile has

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this generally seems reasonable, but I'm far from an AIX expert so you should wait a few days in case other reviewers have feedback. Comment at: clang/

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 304256. Xiangling_L added a comment. Address comments; Move testcases to CodeGen folder instead of CodeGenCXX since ctor/dtor attribute should work in both C&C++ mode; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 2 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false); aaron.ballm

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false); Xiangling_L wrote: > aaron.ballman wrote: > > Xiangling

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 5 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false); aaron.ballm

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false); Xiangling_L wrote: > aaron.ballman wrote: > > There's a

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 6 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false); aaron.ballm

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:276 // extern "C" int atexit(void (*f)(void)); - assert(cast(dtorStub)->getFunctionType() == - llvm::FunctionType::get(CGM.VoidTy, false) && + llvm::PointerType *Expected = + ll

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 303272. Xiangling_L added a comment. Remove unused function parameters; Move testcases to CodeGenCXX folder; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen/CGDeclCXX.cpp cla

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, jasonliu, yusra.syeda, aaron.ballman, sfertile, hfinkel. Herald added a project: clang. Herald added a subscriber: cfe-commits. Xiangling_L requested review of this revision. Support __attribute__((constructor