This revision was automatically updated to reflect the committed changes.
Closed by commit rG4c55c3b66dea: Frontend: Change ComputePreambleBounds to take
MemoryBufferRef, NFC (authored by dexonsmith).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90890/new/
https://reviews.llvm.org/D90890
___
cfe-commits mailing list
cfe
dexonsmith updated this revision to Diff 304195.
dexonsmith added a comment.
Missed a couple of calls from clang-tools-extra. Fixed those.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90890/new/
https://reviews.llvm.org/D90890
Files:
clang-tools-extra/clangd/CodeComplete.cpp
clang
dexonsmith created this revision.
dexonsmith added reviewers: arphaman, JDevlieghere.
Herald added subscribers: usaxena95, ributzka, kadircet.
dexonsmith requested review of this revision.
Avoid requiring an actual MemoryBuffer in ComputePreambleBounds, when a
MemoryBufferRef will do just fine.
