[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

thakis added a comment. In D90871#2433804 , @erik.pilkington wrote: > In D90871#2433766 , @thakis wrote: > >> Looks like this breaks tests on Windows: >> http://45.33.8.238/win/29181/step_7.txt >> >> PTAL, and rev

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington added a comment. In D90871#2433766 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/29181/step_7.txt > > PTAL, and revert while you investigate if it takes a while to fix. Thanks for letting me know, sh

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/29181/step_7.txt PTAL, and revert while you investigate if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.ll

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

This revision was automatically updated to reflect the committed changes. erik.pilkington marked 3 inline comments as done. Closed by commit rG090dd647d98d: [Sema] Fold VLAs to constant arrays in a few more contexts (authored by erik.pilkington). Herald added a project: clang. Changed prior to co

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, that's very clean. Comment at: clang/lib/Sema/SemaDecl.cpp:6027 +/// Attempt to fold a variable-sized type to a constant-sized type, returning +/// true if it we were

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.llvm.org/D90871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington updated this revision to Diff 305506. erik.pilkington added a comment. Use a bit on Declarator instead of an ad-hoc bool parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.llvm.org/D90871 Files: clang/include/clang/Sema/DeclSpec.h cl

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

rsmith added a comment. The direction here seems fine to me. Comment at: clang/include/clang/Sema/Sema.h:2478 - Decl *ActOnDeclarator(Scope *S, Declarator &D); + Decl *ActOnDeclarator(Scope *S, Declarator &D, bool NextTokIsEqual = false); Can we set a `Ha

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington added a reviewer: efriedma. erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.llvm.org/D90871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, rjmccall, arphaman. Herald added subscribers: ributzka, jkorous. erik.pilkington requested review of this revision. D89523 removed support for promoting VLAs to constant arrays when t