[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

foad added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1580 +def int_amdgcn_endpgm : GCCBuiltin<"__builtin_amdgcn_endpgm">, + Intrinsic<[], [], [IntrNoReturn, IntrCold, IntrNoMem, IntrHasSideEffects] The intrinsic def needs a comment.

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23c6d1501d80: [amdgpu] Add `llvm.amdgcn.endpgm` support. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. In D90809#2377221 , @hliao wrote: > In D90809#2377083 , @rampitec wrote: > >> In D90809#2376994

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

hliao marked an inline comment as done. hliao added a comment. In D90809#2377083 , @rampitec wrote: > In D90809#2376994 , @b-sumner wrote: > >> Should this also be IntrConvergent? > > Probably yes... This is control

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

rampitec added a comment. In D90809#2376994 , @b-sumner wrote: > Should this also be IntrConvergent? Probably yes... This is control flow after all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90809/new/

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

b-sumner added a comment. Should this also be IntrConvergent? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90809/new/ https://reviews.llvm.org/D90809 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

hliao marked an inline comment as done. hliao added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1581 +def int_amdgcn_endpgm : GCCBuiltin<"__builtin_amdgcn_endpgm">, + Intrinsic<[], [], [IntrNoReturn, IntrNoMem, IntrHasSideEffects] +>; r

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

hliao updated this revision to Diff 303213. hliao added a comment. Add `IntrCold`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90809/new/ https://reviews.llvm.org/D90809 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/test/CodeGenC

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

rampitec added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1581 +def int_amdgcn_endpgm : GCCBuiltin<"__builtin_amdgcn_endpgm">, + Intrinsic<[], [], [IntrNoReturn, IntrNoMem, IntrHasSideEffects] +>; Mayby also IntrCold? Repository: r

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

hliao created this revision. hliao added reviewers: b-sumner, tony-tye, rampitec, yaxunl. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, hiraditya, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl, arsenm. Herald added projects: clang, LLVM. hliao requested review of this revision