[PATCH] D90767: Add new matchers for dependent names in templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d6e1251d79d: Add new matchers for dependent names in templates (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D907

[PATCH] D90767: Add new matchers for dependent names in templates

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2859 +AST_MATCHER_P(CXXDependentScopeMemberExpr, hasMemberName, std::string, N) { + return Node

[PATCH] D90767: Add new matchers for dependent names in templates

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2859 +AST_MATCHER_P(CXXDependentScopeMemberExpr, hasMemberName, std::string, N) { + return Node.getMember().getAsString() == N; +} aaron.ballman wrote: > steveire wrote: >

[PATCH] D90767: Add new matchers for dependent names in templates

steveire updated this revision to Diff 303462. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90767/new/ https://reviews.llvm.org/D90767 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatc

[PATCH] D90767: Add new matchers for dependent names in templates

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2859 +AST_MATCHER_P(CXXDependentScopeMemberExpr, hasMemberName, std::string, N) { + return Node.getMember().getAsString() == N; +} steveire wrote: > aaron.ballman wrot

[PATCH] D90767: Add new matchers for dependent names in templates

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2859 +AST_MATCHER_P(CXXDependentScopeMemberExpr, hasMemberName, std::string, N) { + return Node.getMember().getAsString() == N; +} aaron.ballman wrote: > This will allow us

[PATCH] D90767: Add new matchers for dependent names in templates

steveire updated this revision to Diff 303271. steveire marked an inline comment as done. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90767/new/ https://reviews.llvm.org/D90767 Files: clang/docs/LibASTMatchersR

[PATCH] D90767: Add new matchers for dependent names in templates

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2838 +/// Matches template-dependent, but known, member names +/// Missing full stop at the end of the comment. Comment at: clang/include/clang/AST

[PATCH] D90767: Add new matchers for dependent names in templates

steveire updated this revision to Diff 302852. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90767/new/ https://reviews.llvm.org/D90767 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatc

[PATCH] D90767: Add new matchers for dependent names in templates

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90767 Files: clang/docs/LibASTMatchersRef