This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7efe07a12b69: Traverse-ignore explicit template
instantiations (authored by stephenkelly).
Changed prior to commit:
https://reviews.llvm.org/D9076
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a tiny commenting request.
Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:506
+if (const auto *CTSD = Node.get()) {
+ auto SK = C
steveire added inline comments.
Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:506
+if (const auto *CTSD = Node.get()) {
+ auto SK = CTSD->getSpecializationKind();
+ if (SK == TSK_ExplicitInstantiationDeclaration ||
aaron.ballman wrote:
> Same
steveire marked 2 inline comments as done.
steveire added inline comments.
Comment at: clang/unittests/AST/ASTTraverserTest.cpp:1092
+
+// Explicit instantiation of template functions do not appear in the AST
+template float timesTwo(float);
aaron.ballman wrote:
steveire updated this revision to Diff 303268.
steveire added a comment.
Uppate
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90763/new/
https://reviews.llvm.org/D90763
Files:
clang/include/clang/AST/ASTNodeTraverser.h
clang/include/clang/ASTM
aaron.ballman added inline comments.
Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:503
TraversalKind Traversal, BindKind Bind) {
+auto ScopedTraversal = TraversingTemplateInstantiationNotSpelledInSource;
+
Please spell this t
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
steveire requested review of this revision.
Continue to dump and match on explicit template specializations, but
omit explicit instantiation declarations
