This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG359e2f988dc5: [clangd] Introduce config parsing for External
blocks (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
kadircet updated this revision to Diff 304060.
kadircet added a comment.
- Preserve location of external block
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90748/new/
https://reviews.llvm.org/D90748
Files:
clang-tools-extra/clangd/ConfigFragme
kadircet added a comment.
> (Meta-point: not sure how useful splitting this patch out from the compile
> step is...)
I wanted to keep them separate especially to ensure testing isn't mixed up. As
these things tend to get big easily :/
Comment at: clang-tools-extra/clangd/Con
kadircet added a comment.
(sorry looks like i forgot to hit submit :( )
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90748/new/
https://reviews.llvm.org/D90748
___
cfe-commits mailing list
cfe-commits@l
kadircet updated this revision to Diff 303824.
kadircet marked 6 inline comments as done.
kadircet added a comment.
- Update comments
- Drop the warning for specifying server on non-grpc builds
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90748/new
sammccall added a comment.
LG (comment nits) thanks!
(Meta-point: not sure how useful splitting this patch out from the compile step
is...)
Comment at: clang-tools-extra/clangd/ConfigFragment.h:165
llvm::Optional> Background;
+/// Configuration information for an exte
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman.
Herald added a project: clang.
kadircet requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Enable configuration of remote and static i
