This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGea4d24c899ea: [Syntax] Tablegen Sequence classes. NFC
(authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D90659?vs=302443&
sammccall added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Nodes.td:123
+Role<"CloseParen", Token<"r_paren">>,
+ ];
+}
gribozavr2 wrote:
> The reason why in my prototype the grammar rules are separate is to allow
> expressing rules that
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Tooling/Syntax/Nodes.td:123
+Role<"CloseParen", Token<"r_paren">>,
+ ];
+}
The reason why in my prototype th
sammccall added a comment.
Again, the generated code is identical to the code being deleted apart from
formatting and the fact that methods are defined inline.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90659/new/
https://reviews.llvm.org/D9065
sammccall created this revision.
sammccall added reviewers: eduucaldas, gribozavr2, hokein.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
sammccall requested review of this revision.
Similar to the previous patch, this doesn't convert *all* the classes that
could be conver
