This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG686d8a0911de: [clangd] Add index server request logging
(authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D90654?vs=30242
sammccall marked 5 inline comments as done.
sammccall added a comment.
Oops, took a while to get back to this.
Planning to land this with some style unaddressed (%/S, --input-file) but
please do LMK if they're important and I'll fix.
Comment at: clang-tools-extra/clangd/test/r
ArcsinX added inline comments.
Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:43
args.index_file, args.project_root
- ],
+ ] + args.server_arg,
stderr=subprocess.PIPE)
this breaks `rem
kadircet added a comment.
I wish there was an easy way to check redacted error logs too :/
Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:335
return std::make_unique(OS, LogLevel);
+llvm::errs() << "non redacted logger\n";
+ }
fee
kbobyrev accepted this revision.
kbobyrev added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:257
+
+ public:
+TextProto(const google::protobuf::Message &M) : M(M) {}
nit
sammccall created this revision.
sammccall added reviewers: kbobyrev, kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman.
Herald added a project: clang.
sammccall requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
- Add verbose logging of payload
