This revision was automatically updated to reflect the committed changes.
Closed by commit rG062b5c598f21: [clangd] Set the User option for clang-tidy to
mimick its behaviour (authored by njames93).
Changed prior to commit:
https://reviews.llvm.org/D90552?vs=302871&id=303519#toc
Repository:
sammccall accepted this revision.
sammccall added a comment.
Still LG
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:812
+EmptyDefaults.User = llvm::sys::Process::GetEnv("USER");
+if (!EmptyDefaults.User)
+ EmptyDefaults.User = llvm::sys::Process::GetEnv(
njames93 updated this revision to Diff 302871.
njames93 marked an inline comment as done.
njames93 added a comment.
Fix typo.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90552/new/
https://reviews.llvm.org/D90552
Files:
clang-tools-extra/clang
njames93 added inline comments.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:812
+EmptyDefaults.User = llvm::sys::Process::GetEnv("USER");
+if (!EmptyDefaults.User)
+ EmptyDefaults.User = llvm::sys::Process::GetEnv("USEUSERNAMER");
sammcc
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:812
+EmptyDefaults.User = llvm::sys::Process::GetEnv("USER");
+if (!EmptyDefaults.User)
+ Empt
njames93 created this revision.
njames93 added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.
njames93 requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Probably not essential as afaik o
