[PATCH] D90531: [clangd] Add clang-tidy options to config

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20b69af7c9c8: [clangd] Add clang-tidy options to config (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 updated this revision to Diff 303598. njames93 added a comment. Fix the unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90531/new/ https://reviews.llvm.org/D90531 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/cl

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 updated this revision to Diff 303596. njames93 marked an inline comment as done. njames93 added a comment. Removed Enable. Removed the scalarBool parser as it was only needed by Enable. Removed DynamicDictParser in favour of reworking DictParser to get better control of how to handle unk

[PATCH] D90531: [clangd] Add clang-tidy options to config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Config.h:78 +std::string Checks; +std::vector> CheckOptions; + } ClangTidy; njames93 wrote: > sammccall wrote: > > I think this should be a StringMap > > > > It makes sense to use a v

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 added inline comments. Comment at: clang-tools-extra/clangd/Config.h:78 +std::string Checks; +std::vector> CheckOptions; + } ClangTidy; sammccall wrote: > I think this should be a StringMap > > It makes sense to use a vector-of-pairs in ConfigF

[PATCH] D90531: [clangd] Add clang-tidy options to config

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Just some simplifications and doc nits left, then please go ahead and land Comment at: clang-tools-extra/clangd/Config.h:74 + + // Configures what clang-tidy

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 updated this revision to Diff 302935. njames93 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90531/new/ https://reviews.llvm.org/D90531 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/clang

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 marked 13 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:183 + struct ClangTidyBlock { +llvm::Optional> Enable; +/// List of checks to enable or disable, can use wildcards. sammccal

[PATCH] D90531: [clangd] Add clang-tidy options to config

sammccall added a comment. Thank you! This design looks really good, just have some nits on comments, possible simplifications etc. (Sorry about the delay getting to these, on it now!) Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:268 + void checkAdjuster(std::st

[PATCH] D90531: [clangd] Add clang-tidy options to config

njames93 updated this revision to Diff 302818. njames93 added a comment. Rebase and make apply take reference to Params. Fix fragments checks being applied on top of each other instead of overwriting the current config checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h