[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2fb114475d1: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux (authored by glaubitz, committed by MaskRay). Changed prior to commi

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Driver/linux-header-search.cpp:266 +// CHECK-DEBIAN-SPARC: "{{[^"]*}}clang{{[^"]*}}" "-cc1" +// CHECK-DEBIAN-SPARC: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]" +// CHECK-DEBIAN-SPARC: "-isysroot" "

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Thanks so much! Would you mind pushing that change for me? I don't have commit access at the moment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524 _

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524 ___ c

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. I changed it to 4.5 to be consisted with the other Multi-Arch tests for x86, MIPS and PowerPC. That's all. Debian Multi-Arch on sparc/sparc64 behaves the exact same way as it does on mips*, powerpc* and x86, so I think it makes sense to use the exact same path pattern

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

phosek added inline comments. Comment at: clang/test/Driver/linux-ld.c:1292 +// CHECK-DEBIAN-SPARC: "{{.*}}/usr/lib/gcc/sparc-linux-gnu/4.5{{/|}}crtbegin.o" +// CHECK-DEBIAN-SPARC: "-L[[SYSROOT]]/usr/lib/gcc/sparc-linux-gnu/4.5" +// CHECK-DEBIAN-SPARC: "-L[[SYSROOT]]/usr/li

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2393747 , @glaubitz wrote: > > No worries. I'm glad someone is taking care of the Solaris parts and > appreciate fixes from other parties. My pleasure: hopefully our work will also be for the benefit of the other party.

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. In D90524#2393746 , @ro wrote: > In D90524#2393651 , @glaubitz wrote: > >> > > > >> Please feel free to reach out to the corresponding debian-$ARCH mailing list >> for such questions. Deb

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2393651 , @glaubitz wrote: > > Please feel free to reach out to the corresponding debian-$ARCH mailing list > for such questions. Debian-specific layouts are not > necessarily obvious at first glance to people not very fa

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. > ! In D90524#2393635 , @ro wrote: > > I had an extremely hard time researching the history of directory layouts for > my patch D85582 . Do as you like, I'm out > of this. Please feel free to re

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2393366 , @glaubitz wrote: > In D90524#2393320 , @ro wrote: > >> In D90524#2393312 , @glaubitz wrote: >> >>> Ping. It would be nice to get this

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro resigned from this revision. ro added a comment. In D90524#2393353 , @glaubitz wrote: > In D90524#2393319 , @ro wrote: > >> In D90524#2388214 , @glaubitz wrote: >> >>> I t

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. In D90524#2393320 , @ro wrote: > In D90524#2393312 , @glaubitz wrote: > >> Ping. It would be nice to get this finally merged so that the testsuite >> noise finally goes down on the sparc64

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. In D90524#2393319 , @ro wrote: > In D90524#2388214 , @glaubitz wrote: > >> I think it should be good for merging now. I addressed all remarks. I'm >> still convinced that "workaround" is t

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2393312 , @glaubitz wrote: > Ping. It would be nice to get this finally merged so that the testsuite noise > finally goes down on the sparc64 Linux worker. Please be a little more patient: one ping a week is considered appro

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2388214 , @glaubitz wrote: > I think it should be good for merging now. I addressed all remarks. I'm still > convinced that "workaround" is the proper term though. Quite the contrary: the comment you cited // FIXME: This

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Ping. It would be nice to get this finally merged so that the testsuite noise finally goes down on the sparc64 Linux worker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524 __

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. I think it should be good for merging now. I addressed all remarks. I'm still convinced that "workaround" is the proper term though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz updated this revision to Diff 303846. glaubitz edited the summary of this revision. glaubitz added a comment. Herald added subscribers: steven.zhang, jrtc27. Update as requested in previous review, also merge with D90549 . Repository: rG LLVM Github M

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Hi Rainer! Thanks for your review. In D90524#2382555 , @ro wrote: > As it happens, I'd arrived at exactly the same patch when I tried a build on > a Debian/sparc64 system in the GCC compile farm (gcc202), submitted as D85582 >

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. As it happens, I'd arrived at exactly the same patch when I tried a build on a Debian/sparc64 system in the GCC compile farm (gcc202), submitted as D85582 . A couple of questions/caveats: - I wouldn't call this patch a workaround, as you do

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. The tests are fixed by this change: https://reviews.llvm.org/D90549. The tests CHECK-DEBIAN-SPARC32 is outdated and does not reflect the fact that sparc and sparc64 use MultiArch on Debian as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Hmm, I'm not sure why the CHECK-DEBIAN-SPARC32 test is failing but I assume the expected output needs to be updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524 __

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz created this revision. glaubitz added a reviewer: nemanjai. Herald added subscribers: cfe-commits, pengfei, fedor.sergeev, jyknight. Herald added a project: clang. glaubitz requested review of this revision. This fixes the Builtins-sparc-linux testsuite failures on Linux SPARC which occur