[PATCH] D90518: [clangd] Make tests depend on Clang

2020-11-02 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai abandoned this revision. smeenai added a comment. Cool, thanks for fixing it better! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90518/new/ https://reviews.llvm.org/D90518 ___ cfe-commits maili

[PATCH] D90518: [clangd] Make tests depend on Clang

2020-10-31 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a subscriber: kbobyrev. sammccall added a comment. D90528 should solve this in a cheaper way. Thanks for raising this though! @kbobyrev @kadircet we were thinking about adding a buildbot with grpc/remote index enabled. Maybe we should have that

[PATCH] D90518: [clangd] Make tests depend on Clang

2020-10-31 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. This would be pretty unfortunate for iteration times: in my workspace having just run `ninja check-clangd`, `ninja clang` has 1450 additional build steps remaining. (All of which would get frequently invalidated e.g. by changes to common LLVM headers). `clangd/test/l

[PATCH] D90518: [clangd] Make tests depend on Clang

2020-10-30 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. smeenai added reviewers: jkorous, kadircet, sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. smeenai requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The clangd lit confi