ahatanak added a comment.
@ille, are you still working on this patch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90434/new/
https://reviews.llvm.org/D90434
___
cfe-commits mailing list
cfe-commits@lis
rjmccall added inline comments.
Comment at: clang/lib/AST/Decl.cpp:2491
+bool VarDecl::isCapturedByOwnInit() const {
+ return hasAttr() && NonParmVarDeclBits.CapturedByOwnInit;
+}
ille wrote:
> rjmccall wrote:
> > You should check `isEscapingByref()` here rather
ille added inline comments.
Comment at: clang/lib/AST/Decl.cpp:2491
+bool VarDecl::isCapturedByOwnInit() const {
+ return hasAttr() && NonParmVarDeclBits.CapturedByOwnInit;
+}
rjmccall wrote:
> You should check `isEscapingByref()` here rather than just `hasAttr`
rjmccall added a comment.
This is great work, thank you.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5349
+def note_because_captured_by_block : Note<
+ "because it is captured by a block used in its own initializer">;
+
This will read okay on
ille added a comment.
Ping :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90434/new/
https://reviews.llvm.org/D90434
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
ille updated this revision to Diff 301966.
ille added a comment.
Satisfy clang-format bot, at the cost of formatting a few adjacent lines.
The other bot failures seem pretty clearly unrelated to this change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
ille created this revision.
ille added reviewers: rjmccall, jfb.
Herald added a project: clang.
ille requested review of this revision.
This is based on my previous patch, https://reviews.llvm.org/D89903, but is an
attempt at a full fix rather than a minimal one, following rjmccall's
suggestion of
