[PATCH] D90330: [NFC][ThinLTO] Change command line passing to EmbedBitcodeInModule

2020-10-28 Thread Mircea Trofin via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6fa35541a0af: [NFC][ThinLTO] Change command line passing to EmbedBitcodeInModule (authored by mtrofin). Changed prior to commit: https://reviews.l

[PATCH] D90330: [NFC][ThinLTO] Change command line passing to EmbedBitcodeInModule

2020-10-28 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm except for the part that should go back into D90278 as noted below. Comment at: llvm/include/llvm/Bitcode/BitcodeWriter.h:165

[PATCH] D90330: [NFC][ThinLTO] Change command line passing to EmbedBitcodeInModule

2020-10-28 Thread Mircea Trofin via Phabricator via cfe-commits
mtrofin created this revision. mtrofin added a reviewer: tejohnson. Herald added subscribers: llvm-commits, cfe-commits, steven_wu, hiraditya, inglorion. Herald added projects: clang, LLVM. mtrofin requested review of this revision. Changing to pass by ref - less null checks to worry about. Rep