[PATCH] D90248: [libomptarget][nvptx] Undef, weak shared variables

2020-10-28 Thread Jon Chesterfield via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d02ca49a294: [libomptarget][nvptx] Undef, weak shared variables (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D90248: [libomptarget][nvptx] Undef, weak shared variables

2020-10-28 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, not totally convinced about weak linkage but ok Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90248/new/ https://reviews.llvm.org/D9

[PATCH] D90248: [libomptarget][nvptx] Undef, weak shared variables

2020-10-27 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, ABataev, grokos, tianshilei1992, ye-luo. Herald added a project: clang. Herald added a subscriber: cfe-commits. JonChesterfield requested review of this revision. [libomptarget][nvptx] Undef, weak shared variables