[PATCH] D90221: Include attribute details when dumping AST in JSON

2020-10-28 Thread Lev Aronsky via Phabricator via cfe-commits
aronsky added a comment. In D90221#2357060 , @aaron.ballman wrote: > In D90221#2356110 , @aronsky wrote: > >> In D90221#2356062 , @lebedev.ri >> wrote: >> >>> Are there tes

[PATCH] D90221: Include attribute details when dumping AST in JSON

2020-10-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D90221#2356110 , @aronsky wrote: > In D90221#2356062 , @lebedev.ri > wrote: > >> Are there tests missing? > > Quite possible. I followed the trail of the existing functions to figu

[PATCH] D90221: Include attribute details when dumping AST in JSON

2020-10-27 Thread Lev Aronsky via Phabricator via cfe-commits
aronsky added a comment. In D90221#2356062 , @lebedev.ri wrote: > Are there tests missing? Quite possible. I followed the trail of the existing functions to figure out the difference between JSON and textual dumping, and tried replicating everything in

[PATCH] D90221: Include attribute details when dumping AST in JSON

2020-10-27 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Are there tests missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90221/new/ https://reviews.llvm.org/D90221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D90221: Include attribute details when dumping AST in JSON

2020-10-27 Thread Lev Aronsky via Phabricator via cfe-commits
aronsky created this revision. aronsky added reviewers: aaron.ballman, steveire. aronsky created this object with visibility "All Users". Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. aronsky requested review of this revision. AST dumps in JSON format were missing a