[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d773a4ff05d: [CMake] Support inter-proto dependencies in generate_protos. (authored by sammccall). Changed prior to commit: https://reviews.llvm.

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

sammccall added inline comments. Comment at: llvm/cmake/modules/FindGRPC.cmake:118 + # DEPENDS arg is a list of "Foo.proto". + foreach(ImportedProto IN LISTS PROTO_DEPENDS) +# Foo.proto -> Foo.pb.h kbobyrev wrote: > sammccall wrote: > > kbobyrev wrote: > >

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

kbobyrev added a comment. LGTM, thanks! Comment at: llvm/cmake/modules/FindGRPC.cmake:118 + # DEPENDS arg is a list of "Foo.proto". + foreach(ImportedProto IN LISTS PROTO_DEPENDS) +# Foo.proto -> Foo.pb.h sammccall wrote: > kbobyrev wrote: > > On line 89

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

sammccall added inline comments. Comment at: llvm/cmake/modules/FindGRPC.cmake:118 + # DEPENDS arg is a list of "Foo.proto". + foreach(ImportedProto IN LISTS PROTO_DEPENDS) +# Foo.proto -> Foo.pb.h kbobyrev wrote: > On line 89 the argument is called `DEPEND

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

kbobyrev added inline comments. Comment at: llvm/cmake/modules/FindGRPC.cmake:118 + # DEPENDS arg is a list of "Foo.proto". + foreach(ImportedProto IN LISTS PROTO_DEPENDS) +# Foo.proto -> Foo.pb.h On line 89 the argument is called `DEPENDS` (also in the com

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

sammccall updated this revision to Diff 300930. sammccall marked an inline comment as done. sammccall added a comment. Move FIXME to more specific place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90215/new/ https://reviews.llvm.org/D90215 Files

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

kadircet added inline comments. Comment at: llvm/cmake/modules/FindGRPC.cmake:117 + # Ensure dependency headers are generated before dependent protos are built. + # FIXME: CMake docs suggest OBJECT_DEPENDS isn't needed, but I can't get the + #recommended add_dependenci

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: llvm-commits, cfe-commits, usaxena95, kadircet, arphaman, mgorny. Herald added projects: clang, LLVM. sammccall requested review of this revision. Repository: rG LLVM Github Monorepo https://review