This revision was automatically updated to reflect the committed changes.
Closed by commit rG2abc33683b2b: [PowerPC] [Clang] Define macros to identify
quad-fp semantics (authored by qiucf).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90208/new/
ht
steven.zhang added a comment.
LGTM now and thank you for the double check. But please hold on for some days
in case someone has concern on enabling the new macros(we are enabling the
__LONG_DOUBLE_IBM128__ by default now).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90208/new/
https
qiucf updated this revision to Diff 302488.
qiucf marked an inline comment as done.
qiucf added a comment.
Keep the `FIXME`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90208/new/
https://reviews.llvm.org/D90208
Files:
clang/lib/Basic/Targets/PPC.cpp
clang/test/CodeGen/ppc64-long
qiucf added inline comments.
Comment at: clang/lib/Basic/Targets/PPC.cpp:122
if (LongDoubleWidth == 128) {
Builder.defineMacro("__LONG_DOUBLE_128__");
Builder.defineMacro("__LONGDOUBLE128");
steven.zhang wrote:
> Can you please double check if we nee
steven.zhang added a comment.
Sorry, accept the revision by mistake. Please hold on until my comments
addressed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90208/new/
https://reviews.llvm.org/D90208
steven.zhang accepted this revision.
steven.zhang added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Basic/Targets/PPC.cpp:122
if (LongDoubleWidth == 128) {
Builder.defineMacro("__LONG_DOUBLE_128__");
Builder.defineMacro("__
qiucf updated this revision to Diff 300887.
qiucf added a comment.
Remove `FIXME`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90208/new/
https://reviews.llvm.org/D90208
Files:
clang/lib/Basic/Targets/PPC.cpp
clang/test/CodeGen/ppc64-long-dou
qiucf created this revision.
qiucf added reviewers: nemanjai, jsji, steven.zhang, PowerPC, kbarton.
Herald added subscribers: cfe-commits, dexonsmith, shchenz.
Herald added a project: clang.
qiucf requested review of this revision.
We have option `-mabi=ieeelongdouble` to set current `long double`
