[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

ArcsinX added a comment. In D90116#2383999 , @kbobyrev wrote: > Sigh, this doesn't work because we have things like > https://docs.microsoft.com/en-us/windows/win32/api/traceloggingprovider/nf-traceloggingprovider-tracelogging_define_provider > and > ht

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

kbobyrev added a comment. Sigh, this doesn't work because we have things like https://docs.microsoft.com/en-us/windows/win32/api/traceloggingprovider/nf-traceloggingprovider-tracelogging_define_provider and https://docs.microsoft.com/en-us/windows/win32/tracelogging/tracelogging-native-quick-st

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d81c8adb6ed: [llvm] CMake: Force MSVC to read code as UTF-8 (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90116/new/ https://reviews.llvm.org/D90116

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

kbobyrev updated this revision to Diff 303942. kbobyrev marked an inline comment as done. kbobyrev added a comment. Omit CXX_COMPILER_ID:MSVC since we're within MSVC section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90116/new/ https://reviews.

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

ArcsinX added inline comments. Comment at: llvm/CMakeLists.txt:604 + add_compile_options("$<$:/utf-8>") + add_compile_options("$<$:/utf-8>") else() I think we could replace these two lines with the one line ``` add_compile_options(/utf-8) ``` Because we could