kbobyrev updated this revision to Diff 300230.
kbobyrev marked 3 inline comments as done.
kbobyrev added a comment.
Remove outdated comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89882/new/
https://reviews.llvm.org/D89882
Files:
clang-to
kbobyrev updated this revision to Diff 300229.
kbobyrev added a comment.
Migrate to proto2 syntax.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89882/new/
https://reviews.llvm.org/D89882
Files:
clang-tools-extra/clangd/index/remote/Index.proto
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/index/remote/Index.proto:15
// structures corresponding to their clangd::* counterparts.
+// NOTE: Enum values are offset by one to detect missing values.
service SymbolIndex {
can we just sw
kbobyrev created this revision.
kbobyrev added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman.
Herald added a project: clang.
kbobyrev requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
This will allow us detect missing values.
