This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd26dd743084a: [clangd] Separate final_result into a
different message (authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE L
kbobyrev updated this revision to Diff 300936.
kbobyrev marked 3 inline comments as done.
kbobyrev added a comment.
Address post-LGTM comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89851/new/
https://reviews.llvm.org/D89851
Files:
clang
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/remote/Index.proto:15
+message FinalResult { optional bool has_more = 1; }
+
this deserves a comment:
kbobyrev updated this revision to Diff 300528.
kbobyrev added a comment.
Rebase on top of master, use proto2 syntax.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89851/new/
https://reviews.llvm.org/D89851
Files:
clang-tools-extra/clangd/index/r
kbobyrev updated this revision to Diff 299705.
kbobyrev added a comment.
Fix proto formatting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89851/new/
https://reviews.llvm.org/D89851
Files:
clang-tools-extra/clangd/index/remote/Client.cpp
clan
kbobyrev created this revision.
kbobyrev added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.
kbobyrev requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Repository:
rG LLVM Github Mono
