[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize Optional

2020-10-28 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. In D89834#2357910 , @dexonsmith wrote: > Dropped `MaybeFileEntryRef`, instead customizing `Optional`. As @arphaman pointed out offline, we can actually `OptionalStorage` instead, by adding add a private constructor to `FileEnt

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize Optional

2020-10-27 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith updated this revision to Diff 301138. dexonsmith retitled this revision from "FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef" to "FileManager: Improve the FileEntryRef API and customize Optional". dexonsmith edited the summary of this revision. dexonsmith added a c