[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

tra closed this revision. tra added a comment. Landed in rGe7fe125b776b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89832/new/ https://reviews.llvm.org/D89832 __

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

emankov added a comment. D89832 eliminates 47332 on Windows as well. Tested against the same CUDA versions as for D89752 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

tra added a comment. In D89832#2349915 , @emankov wrote: > I confirm that D89752 eliminates 47332 > on Windows. Tested against the > following CUDA versions: 7.0, 7,5, 9,2, 1

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

emankov added a comment. I confirm that D89752 eliminates 47332 on Windows. Tested against the following CUDA versions: 7.0, 7,5, 9,2, 10.0, 10,1, 10.2, 11.0 Update 1, 11.1. Repository: rG LLVM Github Monorepo C

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

emankov accepted this revision. emankov added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:76-77 +return CudaVersion::CUDA_102; + if (raw_version < 11010) +return CudaVersion::CUDA_110; + return CudaV

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:76-77 +return CudaVersion::CUDA_102; + if (raw_version < 11010) +return CudaVersion::CUDA_110; + return CudaVersion::LATEST; emankov wrote: > Please, add `CudaVersion::CUDA_111`

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

jlebar accepted this revision. jlebar added a comment. LGTM modulo emankov's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89832/new/ https://reviews.llvm.org/D89832 ___ cfe-commits mailing list

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

emankov requested changes to this revision. emankov added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:76-77 +return CudaVersion::CUDA_102; + if (raw_version < 11010) +return CudaVersion::CUDA_110; + re

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

tra updated this revision to Diff 299501. tra edited the summary of this revision. tra added a comment. Added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89832/new/ https://reviews.llvm.org/D89832 Files: clang/include/clang/Basic/D

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

tra created this revision. tra added reviewers: jlebar, yaxunl, emankov. Herald added subscribers: dexonsmith, bixia. Herald added a project: clang. tra requested review of this revision. This is a follow-up to D89752 , If CUDA version can not be determined based