[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

hokein added a comment. In D89790#2385267 , @thakis wrote: > This breaks compillation on windows when using clang as compiler: > http://45.33.8.238/win/27605/step_4.txt sorry, looking at it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

thakis added a comment. This breaks compillation on windows when using clang as compiler: http://45.33.8.238/win/27605/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89790/new/ https://reviews.llvm.org/D89790 ___

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaa736da10fd: [clangd] Add basic conflict detection for the rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

hokein updated this revision to Diff 303768. hokein marked 3 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89790/new/ https://reviews.llvm.org/D89790 Files: clang-tools-ex

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Just style nits. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:266 + switch (DC->getDeclKind()) { + // The enclosing DeclContext may not be the enc

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:263 + DeclContextLookupResult LookupResult; + switch (DC->getDeclKind()) { + case Decl::TranslationUnit: sammccall wrote: > sammccall wrote: > > explain this list somewhat?

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

hokein updated this revision to Diff 302928. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89790/new/ https://reviews.llvm.org/D89790 Files: clang-tools-extra/cla

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:263 + DeclContextLookupResult LookupResult; + switch (DC->getDeclKind()) { + case Decl::TranslationUnit: explain this list somewhat? e.g. these are the declcontexts which

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. With this patch, we reject the rename if the new nam