This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbb81e7083d25: [clangd] Add basic support for attributes
(selection, hover) (authored by sammccall).
Herald added a project: clang-tools-extra.
Chang
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/unittests/ASTTests.cpp:233
+ };
+ ASSERT_THAT(DeclAttrs("X"), Each(implicitAttr()));
+ ASSERT_THAT(DeclAttrs("Y"), Contains(attrKi
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/AST.cpp:434
+for (AttributedTypeLoc ATL = *ATLPtr; !ATL.isNull();
+ ATL = ATL.getNextTypeLoc().getAs())
+ Result.push_back(ATL.getAttr());
hokein wrote:
> this looks like not s
sammccall updated this revision to Diff 300182.
sammccall added a comment.
Add comment+assert to clarify
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89785/new/
https://reviews.llvm.org/D89785
Files:
clang-tools-extra/clangd/AST.cpp
clang-too
hokein added inline comments.
Comment at: clang-tools-extra/clangd/AST.cpp:434
+for (AttributedTypeLoc ATL = *ATLPtr; !ATL.isNull();
+ ATL = ATL.getNextTypeLoc().getAs())
+ Result.push_back(ATL.getAttr());
this looks like not safe, `getNextTypeLo
sammccall updated this revision to Diff 299957.
sammccall added a comment.
Only deoptimize selection for *explicit* attributes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89785/new/
https://reviews.llvm.org/D89785
Files:
clang-tools-extra/clan
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.
sammccall requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
These aren't terribly common, but
