[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG65d206484c54: [CUDA] Improve clang's ability to detect recent CUDA versions. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89752/new/ htt

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

emankov added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:161 + if (FS.exists(LibDevicePath + "/libdevice.10.bc")) { +Version = CudaVersion::LATEST; +DetectedVersionIsNotSupported = Version > CudaVersion::LATEST_SUPPORTED; -

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:161 + if (FS.exists(LibDevicePath + "/libdevice.10.bc")) { +Version = CudaVersion::LATEST; +DetectedVersionIsNotSupported = Version > CudaVersion::LATEST_SUPPORTED;

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

emankov added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:161 + if (FS.exists(LibDevicePath + "/libdevice.10.bc")) { +Version = CudaVersion::LATEST; +DetectedVersionIsNotSupported = Version > CudaVersion::LATEST_SUPPORTED; -

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra added a comment. In D89752#2344113 , @emankov wrote: > Thank you! > I've successfully applied your change in `Cuda.cpp` to the following clang > versions: `10.0.0`, `10.0.1`, `11.0.0`, and `12.0.0git`; and have created the > working patches (#206 >

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

emankov accepted this revision. emankov added a comment. This revision is now accepted and ready to land. Thank you! I've successfully applied your change in `Cuda.cpp` to the following clang versions: `10.0.0`, `10.0.1`, `11.0.0`, and `12.0.0git`; and have created the working patches (#206

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra added inline comments. Comment at: clang/test/Driver/cuda-version-check.cu:13 // RUN:FileCheck %s --check-prefix=UNKNOWN_VERSION +// CUDA-11.1 does not carry version.txt file. Make sure we still detect it as a +// new version and handle it the same as we handle other new

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra updated this revision to Diff 299410. tra marked 2 inline comments as done. tra added a comment. addresses review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89752/new/ https://reviews.llvm.org/D89752 Files: clang/lib/Driver/Tool

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:161 + if (FS.exists(LibDevicePath + "/libdevice.10.bc")) { +Version = CudaVersion::LATEST; +DetectedVersionIsNotSupported = Version > CudaVersion::LATEST_SUPPORTED;

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

emankov added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:158 if (!VersionFile) { - // CUDA 7.0 doesn't have a version.txt, so guess that's our version if - // version.txt isn't present. - Version = CudaVersion::CUDA_70; + // CUDA 7.

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89752/new/ https://reviews.llvm.org/D89752

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra updated this revision to Diff 299223. tra edited the summary of this revision. tra added a comment. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89752/new/ https://reviews.llvm.org/D89752 Files: clang/lib/Driver/ToolChains/Cud

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

tra created this revision. tra added reviewers: yaxunl, emankov, hans. Herald added a subscriber: bixia. Herald added a project: clang. tra requested review of this revision. CUDA-11.1 does not carry version.txt which causes clang to assume that it's CUDA-7.0, which used to be the only CUDA versio