[PATCH] D89481: [scan-build] Fix clang++ pathname again

2020-11-02 Thread Stephan Bergmann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7a5184ed951a: [scan-build] Fix clang++ pathname again (authored by sberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89481/new/ https://reviews.llvm.org

[PATCH] D89481: [scan-build] Fix clang++ pathname again

2020-11-02 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D89481#2359093 , @sberg wrote: > Is there a reason why "NoQ accepted this revision." kept this at "Needs > Review" rather than moving it to "This revision is now accepted and ready to > land."? Dunno! I think you should commit th

[PATCH] D89481: [scan-build] Fix clang++ pathname again

2020-10-31 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Looks good to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89481/new/ https://reviews.llvm.org/D89481 ___ cfe-commit

[PATCH] D89481: [scan-build] Fix clang++ pathname again

2020-10-28 Thread Stephan Bergmann via Phabricator via cfe-commits
sberg updated this revision to Diff 301273. sberg edited the summary of this revision. sberg added a comment. Is there a reason why "NoQ accepted this revision." kept this at "Needs Review" rather than moving it to "This revision is now accepted and ready to land."? Anyway, I added a test now.

[PATCH] D89481: [scan-build] Fix clang++ pathname again

2020-10-27 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ edited reviewers, added: NoQ, vsavchenko; removed: dergachev.a. NoQ added a comment. Nice, thanks! Since recently we started doing LIT tests for scan-build in `test/Analysis/scan-build`, if you find a good way to test this feature feel free to add a regression te

[PATCH] D89481: [scan-build] Fix clang++ pathname again

2020-10-27 Thread Stephan Bergmann via Phabricator via cfe-commits
sberg added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89481/new/ https://reviews.llvm.org/D89481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D89481: [scan-build] Fix clang++ pathname again

2020-10-15 Thread Stephan Bergmann via Phabricator via cfe-commits
sberg created this revision. sberg added reviewers: aadg, dcoughlin. Herald added a subscriber: Charusso. Herald added a project: clang. sberg requested review of this revision. e00629f777d9d62875730f40d266727df300dbb2 "[scan-build] Fix clang++ pathname" had removed the -MAJOR.MINOR suffix, but si