This revision was automatically updated to reflect the committed changes.
Closed by commit rG747b134d019c: clang/Basic: Remove
SourceManager::getBufferPointer, NFC (authored by dexonsmith).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://r
JDevlieghere added a comment.
Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89430/new/
https://reviews.llvm.org/D89430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dexonsmith added inline comments.
Comment at: clang/lib/Basic/SourceManager.cpp:167
Buffer.setInt(Buffer.getInt() | InvalidFlag);
+return None;
dexonsmith wrote:
> JDevlieghere wrote:
> > Orthogonal to this patch but an idea for a follow-up: this seems
dexonsmith added a comment.
Thanks for the review!
Comment at: clang/lib/Basic/SourceManager.cpp:167
Buffer.setInt(Buffer.getInt() | InvalidFlag);
+return None;
JDevlieghere wrote:
> Orthogonal to this patch but an idea for a follow-up: this seems li
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/Basic/SourceManager.cpp:167
Buffer.setInt(Buffer.getInt() | InvalidFlag);
+return None;
Orthogonal to this
dexonsmith created this revision.
dexonsmith added a reviewer: arphaman.
Herald added a subscriber: ributzka.
dexonsmith requested review of this revision.
Inline `Source::getBufferPointer` into its only remaining caller,
`getBufferOrNone`. No functionality change.
https://reviews.llvm.org/D8943
