This revision was automatically updated to reflect the committed changes.
Closed by commit rG2dc7e0c6a586: clang/Basic: Replace
SourceManager::getMemoryBufferForFile, NFC (authored by dexonsmith).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ht
JDevlieghere accepted this revision.
JDevlieghere added a comment.
Thanks for the explanation!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89429/new/
https://reviews.llvm.org/D89429
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
dexonsmith added inline comments.
Comment at: clang/lib/Basic/SourceManager.cpp:121-127
llvm::Optional
ContentCache::getBufferOrNone(DiagnosticsEngine &Diag, FileManager &FM,
SourceLocation Loc) const {
if (auto *B = getBufferPointer(Diag, FM,
JDevlieghere added inline comments.
Comment at: clang/lib/Basic/SourceManager.cpp:705
+llvm::Optional
+SourceManager::getMemoryBufferForFileOrNone(const FileEntry *File) {
const SrcMgr::ContentCache *IR = getOrCreateContentCache(File);
Would it make sense to r
dexonsmith created this revision.
dexonsmith added a reviewer: arphaman.
Herald added a subscriber: ributzka.
dexonsmith requested review of this revision.
Replace `SourceManager::getMemoryBufferForFile`, which returned a
dereferenceable `MemoryBuffer*` and had a `bool*Invalid` out parameter,
with
