This revision was automatically updated to reflect the committed changes.
Closed by commit rGb3eff6b7bb31: Lexer: Update the Lexer to use
MemoryBufferRef, NFC (authored by dexonsmith).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://review
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/include/clang/Lex/Lexer.h:145
/// outlive it, so it doesn't take ownership of either of them.
- Lexer(FileID FID, const llvm::MemoryBuf
dexonsmith added inline comments.
Comment at: clang/include/clang/Lex/Lexer.h:145
/// outlive it, so it doesn't take ownership of either of them.
- Lexer(FileID FID, const llvm::MemoryBuffer *InputFile, Preprocessor &PP);
+ Lexer(FileID FID, const llvm::MemoryBufferRef &Inpu
dexonsmith added inline comments.
Comment at: clang/include/clang/Lex/Lexer.h:145
/// outlive it, so it doesn't take ownership of either of them.
- Lexer(FileID FID, const llvm::MemoryBuffer *InputFile, Preprocessor &PP);
+ Lexer(FileID FID, const llvm::MemoryBufferRef &Inpu
JDevlieghere added inline comments.
Comment at: clang/include/clang/Lex/Lexer.h:145
/// outlive it, so it doesn't take ownership of either of them.
- Lexer(FileID FID, const llvm::MemoryBuffer *InputFile, Preprocessor &PP);
+ Lexer(FileID FID, const llvm::MemoryBufferRef &In
dexonsmith created this revision.
dexonsmith added a reviewer: arphaman.
Herald added subscribers: usaxena95, ributzka, kadircet.
dexonsmith requested review of this revision.
Update `Lexer` / `Lexer::Lexer` to use `MemoryBufferRef` instead of
`MemoryBuffer*`. Callers that were acquiring a `Memory
