nikic added a comment.
FYI this showed up as a 1% compile-time regression in terms of instructions
retired for `O0-g` builds:
https://llvm-compile-time-tracker.com/compare.php?from=32a4ad3b6ce6028a371b028cf06fa5feff9534bf&to=54c1bcab90102481fe43b73f8547d47446ba2163&stat=instructions
Looking at
This revision was automatically updated to reflect the committed changes.
Closed by commit rG54c1bcab9010: clang/Basic: Stop using
SourceManager::getBuffer, NFC (authored by dexonsmith).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revi
dexonsmith updated this revision to Diff 298152.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89394/new/
https://reviews.llvm.org/D89394
Files:
clang/include/clang/Basic/SourceManager.h
clang/lib/Basic/Diagnostic.cpp
clang/lib/Basic/SourceLocation.cpp
clang/lib/Basic/SourceManag
dexonsmith created this revision.
dexonsmith added a reviewer: arphaman.
Herald added a subscriber: ributzka.
dexonsmith requested review of this revision.
Update `Basic` to stop relying on a `MemoryBuffer*`, using the
`MemoryBufferRef` from `getBufferOrNone` or `getBufferOrFake` instead of
`getBu
